Security fix: Add path validation to analyse_file tool (CWE-22)#251
Open
VadlaReddySai wants to merge 1 commit intogoogle:mainfrom
Open
Security fix: Add path validation to analyse_file tool (CWE-22)#251VadlaReddySai wants to merge 1 commit intogoogle:mainfrom
VadlaReddySai wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
I have signed the CLA. |
Author
|
@googlebot I signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The analyse_file tool was passing user-supplied file_path directly
to open() with no validation, allowing path traversal attacks.
Vulnerability Details
File: server/gti/gti_mcp/tools/files.py, line 263
CWE-22 (Path Traversal) + CWE-200 (Sensitive Data Exposure)
An attacker with MCP client access could call:
analyse_file(file_path="/proc/self/environ")
This causes the server to read its own environment variables
including VT_APIKEY and upload them to VirusTotal.
Fix
Added os.path.realpath() validation to restrict file access
to /tmp/gti-uploads directory before opening any file.